[Webkit-unassigned] [Bug 213728] Remove ENABLE_STREAMS_API compile flag

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=213728

youenn fablet <youennf at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #403056|review?                     |review+
              Flags|                            |

--- Comment #2 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 403056
  --> https://bugs.webkit.org/attachment.cgi?id=403056
Patch

r=me once bots are happy.
Please revert/update some of the changes made to the generator tests.

View in context: https://bugs.webkit.org/attachment.cgi?id=403056&action=review

> Source/JavaScriptCore/ChangeLog:8
> +        I regeneted expectations by Tools/Scripts/run-builtins-generator-tests

regenerated

> Source/JavaScriptCore/Scripts/tests/builtins/WebCore-ArbitraryConditionalGuard-Separate.js:-26
> -// @conditional=ENABLE(STREAMS_API) || USE(CF)

I do not think we want to remove those since they are checking that the generator works fine.
You might want to change the name maybe to make it clear.

> Source/JavaScriptCore/Scripts/tests/builtins/expected/WebCore-DuplicateKeyValueAnnotation-Separate.js-result:1
> +### Begin File: DuplicateKeyValueAnnotationBuiltins.h

I guess this new file has nothing to do with streams API but we somehow forgot to regenerate expectations.
It seems our bots should have caught this missing file.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200629/4d2d7b81/attachment.htm>