[Webkit-unassigned] [Bug 213596] [GTK][WPE] Add webkit_authentication_request_get_security_origin

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=213596

--- Comment #4 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to Michael Catanzaro from comment #3)
> Comment on attachment 402727 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=402727&action=review
> 
> > Source/WebKit/UIProcess/API/glib/WebKitAuthenticationRequest.cpp:368
> > +    return webkitSecurityOriginCreate(SecurityOrigin::create(protocol, protectionSpace.host(), protectionSpace.port()));
> 
> You could ASSERT(!protocol.isEmpty()) here, just in case.
> webkitSecurityOriginCreate really will allow creating an invalid
> WebKitSecurityOrigin with empty protocol.

How can it be empty if it's set to a literal in a switch handling al possible cases?

> > Source/WebKit/UIProcess/API/gtk/WebKitAuthenticationRequest.h:30
> >  #include <webkit2/WebKitCredential.h>
> > +#include <webkit2/WebKitSecurityOrigin.h>
> >  #include <webkit2/WebKitDefines.h>
> 
> It's misalphabetized.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200629/d43d16d8/attachment.htm>