[Webkit-unassigned] [Bug 213543] REGRESSION(r260800): Null Ptr Deref READ @ WTF::Optional<WTF::Seconds>::clear

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=213543

--- Comment #9 from Said Abou-Hallawa <sabouhallawa at apple.com> ---
Comment on attachment 402666
  --> https://bugs.webkit.org/attachment.cgi?id=402666
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=402666&action=review

>>> LayoutTests/fast/rendering/iframe-window-animation-modifies-iframe-srcdoc-crash.html:21
>>> +<video  onloadstart="runTest()">
>> 
>> Alex's suggestion helped, but I think we can do even better here.
>> 
>> From the test harness's perspective by default, the test is over when you hit the closing </html> tag. So, the video loadstart and requestAnimation frame callbacks, which happen asynchronously on a delay, happen after the test harness thinks the test is over. That seems to work, but it's a bit fragile, since the test harness would be well within its rights to just terminate the test before any of that code ran.
>> 
>> testRunner.waitUntilDone() is how we tell the test harness that we want it to wait until some point after the closing </html> tag. And testRunner.notifyDone() is how we tell the test harness we have reached that point.
>> 
>> So, I think you should call testRunner.waitUntilDone() at the top, right after testRunner.dumpAsText(), and then call testRunner.notifyDone() as the last line in srcDocModify().
> 
> Making a note for future reference - waitUntilDone() and notifyDone() was not working for this test. notifyDone was never getting called.

I do not think this is correct. Just follow what Geoffrey said in his comment and the test will not timeout. For quicker verification, you can just add alert messages in runTest() and srcDocModify() and open the test in mini browser and you will see the alert messages pop up as expected.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200624/8080c9d6/attachment.htm>