[Webkit-unassigned] [Bug 213177] [GTK][WPE] Add API to allow applications to handle the HTTP authentication credential storage

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=213177

--- Comment #11 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 402549
  --> https://bugs.webkit.org/attachment.cgi?id=402549
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=402549&action=review

>> Source/WebKit/UIProcess/API/glib/WebKitAuthenticationRequest.cpp:278
>> + * Passing a %NULL @credential will clear the proposed credential.
> 
> When might you want to clear the proposed credential?

When using the internal credential storage and you don't want the dialog to be pre-filled, for example.

>> Tools/TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp:165
>> +    g_assert_true(test->m_authenticationCancelledReceived);
> 
> How about also checking: g_assert_false(test->m_authenticationSucceededReceived)?

We are doing it below, I just forgot to remove this one.

> Tools/TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp:174
> +    g_assert_true(test->m_authenticationCancelledReceived);
> +    g_assert_false(test->m_authenticationSucceededReceived);

Here, it's the same check at the same point.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200624/ed0e04c9/attachment.htm>