[Webkit-unassigned] [Bug 213465] New: Dark mode for GTK themes that end with -Dark or :Dark.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jun 22 09:03:19 PDT 2020


https://bugs.webkit.org/show_bug.cgi?id=213465

            Bug ID: 213465
           Summary: Dark mode for GTK themes that end with -Dark or :Dark.
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: PC
                OS: Linux
            Status: NEW
          Severity: Enhancement
          Priority: P2
         Component: WebKitGTK
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: CheeseEBoi at mailo.com
                CC: bugs-noreply at webkitgtk.org

Created attachment 402481

  --> https://bugs.webkit.org/attachment.cgi?id=402481&action=review

A patch for this issue modifying "Source/WebKit/UIProcess/API/gtk/PageClientImpl.cpp"

WebKitGtk has support for automatic detection of dark mode when it comes to GTK themes with the "-dark" and ":dark" suffixes. However, when using GTK themes that end with "-Dark" or ":Dark", this is not the case. This affects many themes like "Arc" and "Flat-Remix", so adding this funcitonality would be very helpful. 

I have attached to this bug report a possible patch for this, however I am not sure if any other parts of the library need to be modified other than "Source/WebKit/UIProcess/API/gtk/PageClientImpl.cpp". If that is the case, then my patch should be a good example of what needs to be done.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200622/ff2482be/attachment.htm>


More information about the webkit-unassigned mailing list