[Webkit-unassigned] [Bug 213383] -Wsign-compare in isValidOptionSet

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=213383

--- Comment #3 from Michael Catanzaro <mcatanzaro at gnome.org> ---
(In reply to Michael Catanzaro from comment #2)
> So that does work, but I'm going to try to mandate use of unsigned type
> instead. Using signed types with OptionSet is probably a mistake.

So that was a bad idea, because OptionSet goes out of its way to allow this:

using StorageType = std::make_unsigned_t<std::underlying_type_t<E>>;

I think isValidOptionSet should do the same. Let me try that.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200619/5abd31b1/attachment.htm>