[Webkit-unassigned] [Bug 213319] WIP: We should resurrect the older patch that collects some statistics of web API calls

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=213319

--- Comment #4 from Umar Iqbal <uiqbal at apple.com> ---
Comment on attachment 402162
  --> https://bugs.webkit.org/attachment.cgi?id=402162
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=402162&action=review

>> Source/WebCore/ChangeLog:8
>> +        No new tests (OOPS!).
> 
> As long as we make sure that the associated tests are run you can change this to "No new tests. Enabled existing tests."

I will enable the http/tests/webAPIStatistics tests and re-upload along with the specified message.

>> Source/WebCore/loader/ResourceLoadStatistics.cpp:63
>> +static void encodeHashSet(KeyedEncoder& encoder, const String& label,  const String& key, const HashSet<String>& hashSet)
> 
> Was this something that was removed earlier? I'm surprised this is needed.

I brought it back because it was needed by encodeFontHashSet which becomes functional by enabling WEB_API_STATISTICS

>> Source/WebCore/loader/ResourceLoadStatistics.cpp:77
>> +
> 
> Even if we find whitespace errors, we try not to change them unless we are changing the code adjacent to it. Otherwise it makes the revision history hard to read because it looks like you changed something here, for instance deleted code, where in fact you just removed whitespace.

I will update accordingly.

>> Source/WebCore/loader/ResourceLoadStatistics.cpp:129
>> +    encodeHashSet(encoder, "topFrameRegistrableDomainsWhichAccessedWebAPIs", "domain", topFrameRegistrableDomainsWhichAccessedWebAPIs);
> 
> Oh, so this was the reason for the addition of the encodeHashSet() function? This is something you want to call out in the change log – both that you did it and why you did it. "Changed encodeHashCountedSet() to encodeHashSet() because …"
> 
> I'm curious, did you change from counted set to just set?

I changed from counted hash set to hash set because in one of your earlier patch (https://bugs.webkit.org/attachment.cgi?id=363033) you mentioned that the count was never used. So I followed the same principle and updated to hash set.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200619/1acd93ac/attachment-0001.htm>