[Webkit-unassigned] [Bug 213174] [GTK] MiniBrowser: can skip sandboxing without verbose warning

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=213174

--- Comment #8 from Michael Catanzaro <mcatanzaro at gnome.org> ---
Comment on attachment 402204
  --> https://bugs.webkit.org/attachment.cgi?id=402204
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=402204&action=review

>> Source/WebKit/UIProcess/Launcher/glib/BubblewrapLauncher.cpp:684
>> +    g_key_file_set_string(keyFile.get(), "Application", "name", appID ? appID : g_get_prgname());
> 
> This won't work (and can't be made to work)... look three lines up. :P

Sorry... wait... I'm confused. Here you have a GApplication, but it doesn't have an app ID? I didn't realize this was possible. We should probably add this case to the error path above, because the purpose of requiring GApplication is to ensure there is an app ID.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200618/41087fc0/attachment.htm>