[Webkit-unassigned] [Bug 213291] Add support for fetching registrable domains with resource load statistics

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=213291

--- Comment #11 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 402105
  --> https://bugs.webkit.org/attachment.cgi?id=402105
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=402105&action=review

> Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.h:147
> +    Vector<RegistrableDomain> allDomains() const override;

final?

> Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsMemoryStore.h:116
> +    Vector<RegistrableDomain> allDomains() const override;

final?

> Source/WebKit/NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp:1375
> +        postTaskReply([domains = WTFMove(domains), completionHandler = WTFMove(completionHandler)]() mutable {

Hopping to another thread, this requires isolatedCopying domains.

> Source/WebKit/NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp:1378
> +    });

Can we write it with a ternary, something like:
auto domains = m_statisticsStore ? m_statisticsStore->allDomains() : { };
postTaskReply([domains = crossThreadCopy(WTFMove(domains)), completionHandler = WTFMove(completionHandler)]() mutable {
    completionHandler(WTFMove(domains));
});

> Source/WebKit/NetworkProcess/NetworkProcess.cpp:1586
> +                resourceLoadStatistics->registrableDomains([callbackAggregator = callbackAggregator.copyRef()](Vector<RegistrableDomain>&& domains) mutable {

s/Vector<RegistrableDomain>/auto

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200618/29d6d357/attachment-0001.htm>