[Webkit-unassigned] [Bug 213254] Rename TextEncoding::encode() to TextEncoding::encodeWithNormalization()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=213254

Tetsuharu Ohzeki <tetsuharu.ohzeki at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #402015|review-                     |review?
              Flags|                            |

--- Comment #3 from Tetsuharu Ohzeki <tetsuharu.ohzeki at gmail.com> ---
Comment on attachment 402015
  --> https://bugs.webkit.org/attachment.cgi?id=402015
Patch

(In reply to Alexey Proskuryakov from comment #2)
> Comment on attachment 402015 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=402015&action=review
> 
> > Source/WebCore/ChangeLog:9
> > +        I'm planning to add a variant of `TextEncoding::encode()` which does not
> > +        normalize to fix bug 213253.
> 
> I don't think that this is necessary. Once we perform normalization on
> ingress (macOS file names, keyboard input etc.), TextEncoding::encode()
> won't need to normalize ever. There isn't a need for a separate code path.

The exist `TextEncoding::encode()` do normalization in it and it is widely used in evenrywhere in WebKit.
https://trac.webkit.org/browser/webkit/trunk/Source/WebCore/platform/text/TextEncoding.cpp#L77

To fix bug 213253, we need construcing `Blob` object on JavaScript without unicode normalization. I also had a plan to add the function which does not do unicode nomalization as `TextEncoding::encodeWithoutNormalization()` but I thought it's better to rename the exist implementation and I create this separated patch.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200618/d71db9b3/attachment.htm>