[Webkit-unassigned] [Bug 213253] Fix the case about NFC normalization in wpt/FileAPI/unicode.html

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=213253

--- Comment #3 from Tetsuharu Ohzeki <tetsuharu.ohzeki at gmail.com> ---
(In reply to Alexey Proskuryakov from comment #2)
> Comment on attachment 402016 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=402016&action=review
> 
> > Source/WebCore/fileapi/BlobBuilder.cpp:74
> > -    auto bytes = UTF8Encoding().encodeWithNormalization(text, UnencodableHandling::Entities);
> > +    auto bytes = UTF8Encoding().encode(text, UnencodableHandling::Entities);
> 
> While this is correct in abstract, I don't think that we can do this before
> the normalization is performed in all code paths where decomposed text from
> macOS can enter WebKit. And once we do that, encode can stop normalizing.


This effect only for constructing `Blob` API from string on JavaScript.

The exist `TextEncoding::encode()` do normalization in it and it is widely used in evenrywhere in WebKit.
https://trac.webkit.org/browser/webkit/trunk/Source/WebCore/platform/text/TextEncoding.cpp#L77

I had planned to add `TextEncoding::encodeWithoutNormalization()` but I also thought from the comment that it might be better to rename the exist implementation once, I filed bug 213254 and I created this patch built on it.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200618/cbaa8dee/attachment.htm>