[Webkit-unassigned] [Bug 213254] Rename TextEncoding::encode() to TextEncoding::encodeWithNormalization()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=213254

Alexey Proskuryakov <ap at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #402015|review?                     |review-
              Flags|                            |

--- Comment #2 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 402015
  --> https://bugs.webkit.org/attachment.cgi?id=402015
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=402015&action=review

> Source/WebCore/ChangeLog:9
> +        I'm planning to add a variant of `TextEncoding::encode()` which does not
> +        normalize to fix bug 213253.

I don't think that this is necessary. Once we perform normalization on ingress (macOS file names, keyboard input etc.), TextEncoding::encode() won't need to normalize ever. There isn't a need for a separate code path.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200618/67ab4507/attachment.htm>