[Webkit-unassigned] [Bug 212714] Release Assert @ WebCore::RenderTreeBuilder::RenderTreeBuilder

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jun 15 14:41:47 PDT 2020


https://bugs.webkit.org/show_bug.cgi?id=212714

--- Comment #39 from Pinki Gyanchandani <pgyanchandani at apple.com> ---
(In reply to Geoffrey Garen from comment #37)
> Comment on attachment 401808 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=401808&action=review
> 
> r=me
> 
> >> LayoutTests/fast/rendering/widget-removal-in-render-tree-builder-crash.html:38
> >> +<details id="z" open="true" ontoggle="runTest()">a</details>
> > 
> > I am still very skeptical of running test JS in the middle of parsing. Not blocking review, but this could be worth some more effort.
> 
> Pinki, can you test whether this test still fails without your patch if you
> move the call to runTest() into the window load event?

I tried to call runTest with window load event, but then crash is not reproduced, which means the test is meant to be calling runTest in middle of parsing.

Since the test is not causing any regression in bots, will not make any further changes in the code.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200615/971e59b8/attachment.htm>


More information about the webkit-unassigned mailing list