[Webkit-unassigned] [Bug 213190] New: [GTK] WebKitPolicyClient new-window-policy is racey

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=213190

            Bug ID: 213190
           Summary: [GTK]  WebKitPolicyClient new-window-policy is racey
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebKitGTK
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: cturner at igalia.com
                CC: bugs-noreply at webkitgtk.org

In this function in WebKitPolicyClient test,

void beforeAll()
{
    kServer = new WebKitTestServer();
    kServer->run(serverCallback);

    PolicyClientTest::add("WebKitPolicyClient", "navigation-policy", testNavigationPolicy);   // 1
    PolicyClientTest::add("WebKitPolicyClient", "response-policy", testResponsePolicy);       // 2
    PolicyClientTest::add("WebKitPolicyClient", "new-window-policy", testNewWindowPolicy);    // 3
}

If you run any permutations where 3 is not last, you will hit assertions. Placing 3 first gives it the best chance of failing.

The issue is caused due to the piggy timeouts in the new window policy test, they come with a comment,

    // Using a short timeout is a bit ugly here, but it's hard to get around because if we block
    // the new window signal we cannot halt the main loop in the create callback. If we
    // halt the main loop in the policy decision, the create callback never executes.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200615/2afec6d3/attachment.htm>