[Webkit-unassigned] [Bug 213117] Change FileReader.error to DOMException from obsoleted FileError

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=213117

Chris Dumez <cdumez at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #401726|review?                     |review+, commit-queue-
              Flags|                            |

--- Comment #4 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 401726
  --> https://bugs.webkit.org/attachment.cgi?id=401726
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=401726&action=review

r=me with changes.

> Source/WebCore/fileapi/FileReader.cpp:226
> +        RefPtr<DOMException> exception = DOMException::create(e.exception());

We don't need this local variable. This can be:
m_error = DOMException::create(e.exception());

> Source/WebCore/fileapi/FileReader.h:73
> +    RefPtr<DOMException> error() { return m_error; }

This should return a DOMException*, not need to ref:
DOMException* error() const { return m_error.get(); }

> Source/WebCore/fileapi/FileReader.idl:55
> +    readonly attribute DOMException error;

This should be:
readonly attribute DOMException? error;

As per spec, since it can return null.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200612/df8e7a20/attachment.htm>