[Webkit-unassigned] [Bug 212898] [GTK] MiniBrowser: stop using GtkToolbar

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=212898

--- Comment #3 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to Adrian Perez from comment #2)
> Comment on attachment 401332 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=401332&action=review
> 
> > Tools/MiniBrowser/gtk/BrowserWindow.c:473
> > +    return webkit_web_view_get_zoom_level(webView) != 1.0;
> 
> Comparing floating point numbers is usually a bad idea, due to rounding
> errors
> and whatnot. Probably not much of an issue here, but the safest would be
> rounding
> to the nearest integer and comparing that:
> 
>   return lrint(webkit_web_view_get_zoom_level(webView)) == 1;
> 
> No strong opinion, though. Feel free to leave the code as-is if you prefer.

I don't think it's a problem in this case because 1.0 is set when the load completes, which is what we want to check here.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200612/6da3d3a3/attachment.htm>