[Webkit-unassigned] [Bug 210276] [GTK4] Get MiniBrowser ready for GTK4

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=210276

Adrian Perez <aperez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |aperez at igalia.com
 Attachment #401632|review?                     |review+
              Flags|                            |

--- Comment #2 from Adrian Perez <aperez at igalia.com> ---
Comment on attachment 401632
  --> https://bugs.webkit.org/attachment.cgi?id=401632
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=401632&action=review

> Tools/MiniBrowser/gtk/BrowserSearchBox.c:74
> +    action = g_action_map_lookup_action(G_ACTION_MAP(searchBox->actionGroup), "beginnig-word");

Typo: beginnig → beginning.

I saw this in one of the dependant patches, so if you fix it on the other
patch first I suppose when you rebase this one you'll get it fixed, too :)

> Tools/MiniBrowser/gtk/BrowserSearchBox.c:131
> +    gtk_editable_set_text(GTK_EDITABLE(searchBox->entry), "");

I was about to mention this could be in “GtkVersioning.h”, but of
course we only want to use public headers in the MiniBrowser ��️

Maybe it would be neat to have such a header for the MiniBrowser?
My feeling is that it would simplify quite a lot the #if-#endif
churn in many places along this patch.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200612/ed85fe02/attachment-0001.htm>