[Webkit-unassigned] [Bug 213037] Stop to use ActiveDOMObject::setPendingActivity() for WebCore/Modules/fetch

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=213037

--- Comment #9 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 401652
  --> https://bugs.webkit.org/attachment.cgi?id=401652
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=401652&action=review

> Source/WebCore/Modules/fetch/FetchBodyOwner.cpp:260
> +    setPendingActivity();

This one..

> Source/WebCore/Modules/fetch/FetchBodyOwner.cpp:269
> +    unsetPendingActivity();

... and this one are easily avoidable by..

> Source/WebCore/Modules/fetch/FetchBodyOwner.cpp:391
> +    return m_pendingInstanceCount > 0;

... doing this:
return !!m_blobLoader;

This way, the wrapper will be kept alive as long as we have blob loader.

> Source/WebCore/Modules/fetch/FetchBodySource.cpp:45
> +        m_bodyOwner->setPendingActivity();

For these, maybe the caller should call makePendingActivity() instead and store the pending activity here.

> Source/WebCore/Modules/fetch/FetchBodySource.cpp:52
> +        m_bodyOwner->unsetPendingActivity();

Then clear the pending activity they stored, here.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200611/edd3ed66/attachment.htm>