[Webkit-unassigned] [Bug 213037] Stop to use ActiveDOMObject::setPendingActivity() for WebCore/Modules/fetch

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=213037

--- Comment #7 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 401652
  --> https://bugs.webkit.org/attachment.cgi?id=401652
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=401652&action=review

>> Source/WebCore/Modules/fetch/FetchBodyOwner.h:138
>> +    unsigned m_pendingInstanceCount { 0 };
> 
> I seem that it might be good to provide a way to increment/decrement ActiveDOMObject::m_pendingActivityInstanceCount instead of holding and manipulate this member.
> 
> Why did we obsolete ActiveDOMObject::setPendingActivity() in bug 209754?
> I could not find the reason for its change.

mismatched setPendingActivity() / unsetPendingActivity() calls was a frequent source of leaks. The modern way to keep the JS wrapper alive is to call makePendingActivity() and store the returned object, as documented in the code. This makes it a bit harder to make mistakes.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200611/3604428b/attachment.htm>