[Webkit-unassigned] [Bug 212898] [GTK] MiniBrowser: stop using GtkToolbar

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=212898

Adrian Perez <aperez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |aperez at igalia.com
 Attachment #401332|review?                     |review+
              Flags|                            |

--- Comment #2 from Adrian Perez <aperez at igalia.com> ---
Comment on attachment 401332
  --> https://bugs.webkit.org/attachment.cgi?id=401332
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=401332&action=review

> Tools/MiniBrowser/gtk/BrowserWindow.c:473
> +    return webkit_web_view_get_zoom_level(webView) != 1.0;

Comparing floating point numbers is usually a bad idea, due to rounding errors
and whatnot. Probably not much of an issue here, but the safest would be rounding
to the nearest integer and comparing that:

  return lrint(webkit_web_view_get_zoom_level(webView)) == 1;

No strong opinion, though. Feel free to leave the code as-is if you prefer.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200611/5daa370a/attachment.htm>