[Webkit-unassigned] [Bug 212967] scrollingcoordinator/ios/scroll-position-after-reattach.html is a flaky image failure

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 9 05:37:57 PDT 2020


https://bugs.webkit.org/show_bug.cgi?id=212967

Antoine Quint <graouts at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |graouts at webkit.org
 Attachment #401434|review?                     |review+
              Flags|                            |

--- Comment #3 from Antoine Quint <graouts at webkit.org> ---
Comment on attachment 401434
  --> https://bugs.webkit.org/attachment.cgi?id=401434
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=401434&action=review

> LayoutTests/scrollingcoordinator/ios/scroll-position-after-reattach.html:33
>      let removed = outercontent;
>      outercontent.remove();

While you're modifying this test, you can remove the `removed` variable which is useless, `outercontent` can be used.

> LayoutTests/scrollingcoordinator/ios/scroll-position-after-reattach.html:36
> +    await new Promise(requestAnimationFrame);

Since this test is already pulling in `UIHelper`, you can use `UIHelper.animationFrame()`.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200609/992a2aff/attachment.htm>


More information about the webkit-unassigned mailing list