[Webkit-unassigned] [Bug 212714] Release Assert @ WebCore::RenderTreeBuilder::RenderTreeBuilder

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=212714

--- Comment #2 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 400966
  --> https://bugs.webkit.org/attachment.cgi?id=400966
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=400966&action=review

> Source/WebCore/ChangeLog:8
> +        Widget Removal in middle of building a Render Tree causes side effects, leading to Release Assert. Moved the scope for suspension of widgets

Removal => removal

in middle => in the middle

> Source/WebCore/ChangeLog:9
> +        update to RenderTreeBuilder instead of having it at RenderTreeUpdater. 

at RenderTreeUpdater => in RenderTreeUpdater

> Source/WebCore/ChangeLog:11
> +        Also made sure that the WidgetHierarchyUpdatesSuspensionScope::moveWidgets(), should handle all widgets scheduled for move. 

WidgetHierarchyUpdatesSuspensionScope::moveWidgets(), => WidgetHierarchyUpdatesSuspensionScope::moveWidgets()

scheduled for move. => scheduled to move, including new widgets scheduled during moveWidgets().

> Source/WebCore/rendering/updating/RenderTreeBuilder.h:66
> +    WidgetHierarchyUpdatesSuspensionScope suspendWidgetHierarchyUpdates;

WebKit style puts data members together at the end of the class definition, and prefixes data members with "m_". 

I would put this declaration right above "RenderView& m_view" and call it "WidgetHierarchyUpdatesSuspensionScope m_widgetHierarchyUpdatesSuspensionScope".

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200603/aef723cb/attachment.htm>