[Webkit-unassigned] [Bug 207828] AX: Adopt _AXSCopyPathForAccessibilityBundle for WebKit

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=207828

Andy Estes <aestes at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |aestes at apple.com

--- Comment #10 from Andy Estes <aestes at apple.com> ---
Comment on attachment 391264
  --> https://bugs.webkit.org/attachment.cgi?id=391264
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=391264&action=review

> Source/WTF/wtf/PlatformHave.h:423
> -#if PLATFORM(IOS_FAMILY) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 130000 && __IPHONE_OS_VERSION_MAX_ALLOWED >= 130100
> +#if PLATFORM(IOS_FAMILY) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 140000

This means that HAVE_ACCESSIBILITY_BUNDLES_PATH is undefined on tvOS and watchOS (because __IPHONE_OS_VERSION_MIN_REQUIRED will never be >= 140000 on those platforms). Was that your intention?

Filed <https://webkit.org/b/212704> HAVE(ACCESSIBILITY_BUNDLES_PATH) is defined in terms of PLATFORM(IOS_FAMILY) but only checks the version of __IPHONE_OS_VERSION_MIN_REQUIRED

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200603/6ca4a8fd/attachment-0001.htm>