[Webkit-unassigned] [Bug 212704] New: HAVE(ACCESSIBILITY_BUNDLES_PATH) is defined in terms of PLATFORM(IOS_FAMILY) but only checks the version of __IPHONE_OS_VERSION_MIN_REQUIRED

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=212704

            Bug ID: 212704
           Summary: HAVE(ACCESSIBILITY_BUNDLES_PATH) is defined in terms
                    of PLATFORM(IOS_FAMILY) but only checks the version of
                    __IPHONE_OS_VERSION_MIN_REQUIRED
           Product: WebKit
           Version: WebKit Local Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Platform
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: aestes at apple.com

HAVE_ACCESSIBILITY_BUNDLES_PATH is defined like so:

>#if PLATFORM(IOS_FAMILY) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 140000
>#define HAVE_ACCESSIBILITY_BUNDLES_PATH 1
>#endif

The use of PLATFORM(IOS_FAMILY) suggests we should enable this HAVE() on some tvOS and watchOS platforms, but __IPHONE_OS_VERSION_MIN_REQUIRED will never be >= 140000 on these platforms.

If we only intend to support iOS, we should change PLATFORM(IOS_FAMILY) to PLATFORM(IOS). Otherwise, we need to add a version check for each platform we intend to support, e.g.:

>(PLATFORM(IOS) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 130000) \
>    || (PLATFORM(WATCHOS) && __WATCH_OS_VERSION_MIN_REQUIRED >= 60000) \
>    || (PLATFORM(APPLETV) && __TV_OS_VERSION_MIN_REQUIRED >= 130000)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200603/f46965cf/attachment.htm>