[Webkit-unassigned] [Bug 212693] New: Read MediaPlayerPrivateMediaStreamAVFObjC::m_canEnqueueDisplayLayer after the lock

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=212693

            Bug ID: 212693
           Summary: Read
                    MediaPlayerPrivateMediaStreamAVFObjC::m_canEnqueueDisp
                    layLayer after the lock
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebRTC
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: youennf at gmail.com
                CC: youennf at gmail.com

Read MediaPlayerPrivateMediaStreamAVFObjC::m_canEnqueueDisplayLayer after the lock.
As spotted by Eric, there might be an edge case where m_canEnqueueDisplayLayer check would be bypassed:
- enqueueVideoSample is called in a background thread, checks m_canEnqueueDisplayLayer which is true and pauses just after the check.
- destroyLayers is called, which sets m_canEnqueueDisplayLayer to false.
- ensureLayers recreates the display layer which is then not yet initialized
- enqueueVideoSample continues and will try to enqueue the sample while m_canEnqueueDisplayLayer is false.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200603/d89775fe/attachment.htm>