[Webkit-unassigned] [Bug 212642] Use WTF::Optional for the 2nd argument of FileReaderLoader

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=212642

--- Comment #4 from Tetsuharu Ohzeki <tetsuharu.ohzeki at gmail.com> ---
(In reply to Darin Adler from comment #3)
> Comment on attachment 400832 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=400832&action=review
> 
> >> Source/WebCore/ChangeLog:3
> >> +        Use WTF::Optional for the 2nd argument of FileReaderLoader
> > 
> > Why?
> 
> Pointers are intrinsically "optional" and we use nullptr to mean "no value".

I know it.
First, I had thought replacing this `0` to `nullptr`.
https://trac.webkit.org/browser/webkit/trunk/Source/WebCore/fileapi/FileReaderSync.cpp#L48

But I think it maybe better to use WTF::Optional.
To make it more simply, Is replacing nullptr best?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200602/6e0d2b79/attachment-0001.htm>