[Webkit-unassigned] [Bug 212322] [GTK4] Implement file chooser

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=212322

--- Comment #11 from Adrian Perez <aperez at igalia.com> ---
(In reply to Carlos Garcia Campos from comment #10)
> (In reply to Santosh Mahto from comment #8)
> > Thanks Adrian Perez.
> > Updated the patch again with some cleanups, so request you to look again.
> > 
> > btw, gtk-ews fails to compile this patch, but it looks like its building
> > wrongly, seems like USE_GTK4 is enabled but GTK3 based sdk are used. Do we
> > have EWS enabled 
> > for GTK4 ?
> 
> I think you need to update WebKit and rebase the patch, there's now and
> #else in GtkVersioning.h, it seems the new functions are added after the
> #else, so for GTK3. We don't EWS for GTK4 yet.

Yes, that is exactly the problem. I tried applying the patch locally and
the new functions get added after the #else.

Santosh, could you please make sure to pull the latest changes from the
repository and update the patch? Thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200602/a1dd79ef/attachment.htm>