[Webkit-unassigned] [Bug 198578] Implement ParentNode.prototype.replaceChildren

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=198578

--- Comment #7 from Tetsuharu Ohzeki <tetsuharu.ohzeki at gmail.com> ---
(In reply to Darin Adler from comment #6)
> I don’t see the value in factoring this out as a named function. The
> pre-condition that you must already have checked pre-insertion validity
> makes it hard to use this correctly. I suggest just including this code in
> ContainerNode::replaceChildren for now, and factoring it out only if we find
> we have a good way to share code with other call sites.

Thank you review!
Okay. I'll change like that.


> I don’t understand why it is OK that this does not use
> executeNodeInsertionWithScriptAssertion.

As my understanding, ContainerNode::appendChildWithoutPreInsertionValidityCheck calls executeNodeInsertionWithScriptAssertion internally and appendChildWithoutPreInsertionValidityCheck has additional operations related to there is a parent.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200601/57aa4949/attachment.htm>