[Webkit-unassigned] [Bug 176576] check-webkit-style shouldn't check *Prefix.cpp for [build/include_order]

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jun 1 08:15:28 PDT 2020


https://bugs.webkit.org/show_bug.cgi?id=176576

--- Comment #4 from Jonathan Bedard <jbedard at apple.com> ---
Comment on attachment 320220
  --> https://bugs.webkit.org/attachment.cgi?id=320220
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=320220&action=review

> Tools/Scripts/webkitpy/style/checker.py:252
> +    ([# *Prefix.cpp files don't follow the include order rules.

This actually isn't a rule we can easily (or rather, should) change, it's coming from the automatic Python style checker.

Seems like we should just make this line conform with the rule (which would entail adding a space after [ or putting the comment on a new line)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200601/18f1930f/attachment-0001.htm>


More information about the webkit-unassigned mailing list