[Webkit-unassigned] [Bug 212322] [GTK4] Implement file chooser

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=212322

--- Comment #6 from Adrian Perez <aperez at igalia.com> ---
(In reply to Santosh Mahto from comment #5)
> (In reply to Adrian Perez from comment #4)
> >
> > [...]
> > 
> > > Source/WebCore/platform/gtk/GtkVersioning.h:178
> > > +        gchar* uri = g_file_get_path(static_cast<GFile*>(node->data));
> > 
> > The documentation for gtk_file_chooser_get_filenames() says:
> > 
> >    “If files in the current folder cannot be represented as
> >     local filenames they will be ignored.“
> > 
> > Therefore we need to check here whether the GFile is local or
> > not, and skip adding the non-local ones to the result list. I
> > think that using g_file_is_native() would fit well.
> 
> As per doc g_file_get_path seems to only return localname
> "Gets the local pathname for GFile, if one exists. If non-NULL, this is
> guaranteed to be an absolute, canonical path. It might contain symlinks.".

Good point. I should have read the documentation for g_file_get_path()
before assuming it would return non-NULL for non-local files. No need to
change this, then.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200601/6f27c2b6/attachment-0001.htm>