[Webkit-unassigned] [Bug 214978] [macOS] Date/time input types should have a textfield appearance

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=214978

Wenson Hsieh <wenson_hsieh at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #405694|review?                     |review+
              Flags|                            |

--- Comment #4 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 405694
  --> https://bugs.webkit.org/attachment.cgi?id=405694
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=405694&action=review

> Source/WebCore/rendering/RenderThemeMac.mm:402
> +    return "input[type=\"week\"] { -webkit-appearance: textfield; align-items: center; display: -webkit-inline-flex; overflow: hidden; width: 10em; outline: none; } "_s;

This seems fine for now, but given that they’re all the same style rules, we might want to consider just refactoring these styles to be under something like `RenderTheme::dateAndTimeInputStyleSheet()`, or to be inside html.css as "input[type=date], input[type=time], … { … }".

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200731/3c22c1c9/attachment.htm>