[Webkit-unassigned] [Bug 214958] Web Inspector: Hide clipped timeline markers
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jul 30 12:52:35 PDT 2020
https://bugs.webkit.org/show_bug.cgi?id=214958
--- Comment #9 from Nikita Vasilyev <nvasilyev at apple.com> ---
Comment on attachment 405549
--> https://bugs.webkit.org/attachment.cgi?id=405549
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=405549&action=review
>> Source/WebInspectorUI/UserInterface/Views/TimelineRuler.js:639
>> + element.classList.toggle("before-selection", newPositionAprox <= 0);
>
> Shouldn't it only be `< 0`? I think we probably should show the marker if it's exactly at `0`.
An empty timeline has a red marker at 0. The main point of this patch was to hide it.
--
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200730/b1bd973f/attachment.htm>
More information about the webkit-unassigned
mailing list