[Webkit-unassigned] [Bug 214958] Web Inspector: Hide clipped timeline markers

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=214958

Devin Rousso <drousso at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #405549|review?                     |review-
              Flags|                            |

--- Comment #5 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 405549
  --> https://bugs.webkit.org/attachment.cgi?id=405549
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=405549&action=review

r- due to the issue above

> Source/WebInspectorUI/UserInterface/Views/OverviewTimelineView.css:30
> +    overflow: initial;

Does this actually do anything?

> Source/WebInspectorUI/UserInterface/Views/TimelineRuler.css:135
> +.timeline-ruler > .markers > .marker.before-selection {
> +    display: none;
> +}

Why is this needed?

> Source/WebInspectorUI/UserInterface/Views/TimelineRuler.js:639
> +            element.classList.toggle("before-selection", newPositionAprox <= 0);

Shouldn't it only be `< 0`?  I think we probably should show the marker if it's exactly at `0`.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200730/fb359217/attachment.htm>