[Webkit-unassigned] [Bug 214954] check-webkit-style should enforce acronym capitalization at start/end of an identifier
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jul 29 18:30:13 PDT 2020
https://bugs.webkit.org/show_bug.cgi?id=214954
--- Comment #1 from David Kilzer (:ddkilzer) <ddkilzer at webkit.org> ---
We can now find the incorrectly capitalized identifiers in DumpRenderTree.mm:
$ ./Tools/Scripts/check-webkit-style --filter-rules=-,+readability/naming/acronym Tools/DumpRenderTree/mac/DumpRenderTree.mm
ERROR: Tools/DumpRenderTree/mac/DumpRenderTree.mm:297: The identifier name "URLString" starts with a acronym that is not all lowercase. [readability/naming/acronym] [5]
ERROR: Tools/DumpRenderTree/mac/DumpRenderTree.mm:1648: The identifier name "testPathOrUrl" ends with a acronym that is not all uppercase. [readability/naming/acronym] [5]
ERROR: Tools/DumpRenderTree/mac/DumpRenderTree.mm:1650: The identifier name "localPathOrUrl" ends with a acronym that is not all uppercase. [readability/naming/acronym] [5]
Total errors found: 3 in 1 files
And verify that Source/WTF has no incorrectly named variables (might be false negatives, but no false positives):
$ ./Tools/Scripts/check-webkit-style --filter-rules=-,+readability/naming/acronym Source/WTF
Total errors found: 0 in 828 files
--
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200730/9755a9e1/attachment-0001.htm>
More information about the webkit-unassigned
mailing list