[Webkit-unassigned] [Bug 213947] [GStreamer] media/vp9.html failing since check-in in r263894

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=213947

--- Comment #11 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
(In reply to Darin Adler from comment #10)
> Comment on attachment 405285 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=405285&action=review
> 
> > Source/WebCore/testing/Internals.cpp:5531
> > +#if PLATFORM(MAC) || PLATFORM(IOS) || PLATFORM(MACCATALYST)
> > +    return true;
> > +#else
> > +    return false;
> > +#endif
> 
> This is an incorrect implementation. Will return false for watchOS and tvOS.
> Simpler is to just write PLATFORM(COCOA).

Ok,

> Not thrilled with the name of this. It seems imprecise. It will return false
> if you are running on Apple hardware but with a non-Apple port of WebKIt,
> and will return false if you are running on Windows with an Apple port of
> WebKit.

I'll name it isApplePort.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200728/73038d18/attachment-0001.htm>