[Webkit-unassigned] [Bug 214809] -Wdeprecated-copy caused by DisallowVMEntry copy constructor

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=214809

--- Comment #3 from Mark Lam <mark.lam at apple.com> ---
(In reply to Michael Catanzaro from comment #0)
...
> DerivedSources/WebCore/unified-sources/UnifiedSource-68aea4ac-6.cpp:1:
> DerivedSources/ForwardingHeaders/JavaScriptCore/DisallowVMEntry.h:46:5:
> note: because ‘JSC::DisallowVMEntryImpl<JSC::VM>’ has user-provided
> ‘JSC::DisallowVMEntryImpl<VMType>::DisallowVMEntryImpl(const
> JSC::DisallowVMEntryImpl<VMType>&) [with VMType = JSC::VM]’
>    46 |     DisallowVMEntryImpl(const DisallowVMEntryImpl& other)
>       |     ^~~~~~~~~~~~~~~~~~~
> 
> Problem is the code makes a copy of the DisallowVMEntryImpl, and this copy
> fails to increment the VM's disallowVMEntryCount. But disallowVMEntryCount
> will be decremented when the DisallowVMEntryImpl is destroyed. ***I think
> that results in underflow.***
> 
> Let's add a copy constructor.

Looking at the original patch, my copy constructor does increment vm->disallowVMEntryCount.  What am I missing?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200726/97614668/attachment.htm>