[Webkit-unassigned] [Bug 214707] Remove definition of NSImageSymbolScale, which is part of the beta 3 SDK

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jul 24 09:36:33 PDT 2020


https://bugs.webkit.org/show_bug.cgi?id=214707

--- Comment #6 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 405109
  --> https://bugs.webkit.org/attachment.cgi?id=405109
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=405109&action=review

But also, we should probably add preprocessor checks in this file, as nothing here says that this is new with Big Sur.

Looks like using these is guarded by HAVE(ALTERNATE_ICONS).

> Source/WebCore/PAL/pal/spi/mac/NSImageSPI.h:39
>  extern const NSImageHintKey NSImageHintSymbolFont;
>  extern const NSImageHintKey NSImageHintSymbolScale;

Are these still not part of SDK, even though NSImageSymbolScale is?

> Source/WebCore/PAL/pal/spi/mac/NSImageSPI.h:42
>  - (void)lockFocusWithRect:(NSRect)rect context:(nullable NSGraphicsContext *)context hints:(nullable NSDictionary *)hints flipped:(BOOL)flipped;

Not seeing an underscore makes me wonder if this is SDK too.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200724/2b328dfc/attachment.htm>


More information about the webkit-unassigned mailing list