[Webkit-unassigned] [Bug 214660] New: markContextChangedAndNotifyCanvasObserver and markContextChanged over-notify

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=214660

            Bug ID: 214660
           Summary: markContextChangedAndNotifyCanvasObserver and
                    markContextChanged over-notify
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebGL
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: kbr at google.com
                CC: dino at apple.com
        Depends on: 212461

WebGLRenderingContextBase::markContextChanged and WebGLRenderingContextBase::markContextChangedAndNotifyCanvasObserver dispatch too many notifications:

- markContextChangedAndNotifyCanvasObserver doesn't take into account whether a user-level framebuffer is bound. If one is, then it shouldn't notify.
- markContextChanged calls "htmlCanvas()->clearCopiedImage()" and "renderBox->contentChanged(CanvasPixelsChanged)" for every draw call - this seems expensive.

dino@ indicated in discussion on Slack that with the addition of WebGLRenderingContextBase::prepareForDisplay in Bug 212461, at least some of these notifications can be done once per frame, at the end of the frame, rather than on each operation that might touch the WebGL back buffer.


Referenced Bugs:

https://bugs.webkit.org/show_bug.cgi?id=212461
[Bug 212461] AutoTrader crashed while browsing search results
-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200722/05edd5e1/attachment.htm>