[Webkit-unassigned] [Bug 213493] [WPE][GTK] Add API to support "Privacy Report"

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=213493

Adrian Perez <aperez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |aperez at igalia.com
 Attachment #404913|review?                     |review+
              Flags|                            |

--- Comment #18 from Adrian Perez <aperez at igalia.com> ---
Comment on attachment 404913
  --> https://bugs.webkit.org/attachment.cgi?id=404913
Patch

Patch LGTM overall, but there are a couple of types and a an introspection
annotation which needs fixing, so please check the comments below before landing.

View in context: https://bugs.webkit.org/attachment.cgi?id=404913&action=review

> Source/WTF/ChangeLog:8
> +        Add support for using GRePtr with GDateTime.

Typo: GRePtr → GRefPtr

> Source/WebKit/ChangeLog:8
> +        Add WebKitITPFirstParty and WebKitITPThirdParty bosex types to expose the data returned by the ITP summary.

Typo: bosex → boxed

> Source/WebKit/UIProcess/API/glib/WebKitWebsiteDataManager.cpp:1221
> + * Returns: (transfer full): the last update time as a #GDateTime

The implementation returns the pointer directly, without adding a
reference, therefore the annotation here should be “(transfer none)”.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200722/52de494a/attachment.htm>