[Webkit-unassigned] [Bug 214589] REGRESSION(r264639): Intl.DisplayNames tests failing on all architectures

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=214589

--- Comment #4 from Michael Catanzaro <mcatanzaro at gnome.org> ---
(In reply to Michael Catanzaro from comment #1)
> The test expects regionNames.of('BZ') to return "Belize" but it is returning
> "BZ" because HAVE_ICU_U_LOCALE_DISPLAY_NAMES requires ICU 61, but RHEL 8
> uses ICU 60. 

I think our internal CI may be using some custom environment with a strange version of ICU. I've asked to learn more. I thought it more likely that $vm.icuVersion() was returning a bogus result, but it seems to work perfectly fine on my desktop with ICU 65.1 (where it returns "65").

Both these tests are broken on my desktop in addition to our CI. To make the tests pass, I had to do this:

diff --git a/JSTests/stress/intl-displaynames.js b/JSTests/stress/intl-displaynames.js
index ff15457fb37..d39437ac423 100644
--- a/JSTests/stress/intl-displaynames.js
+++ b/JSTests/stress/intl-displaynames.js
@@ -62,10 +62,7 @@ if ($vm.icuVersion() >= 61) {
     shouldBe(languageNames.of('fr'), "French");
     shouldBe(languageNames.of('de'), "German");
     shouldBe(languageNames.of('fr-CA'), "Canadian French");
-    if ($vm.icuVersion() >= 64 && $vm.icuVersion() <= 66)
-        shouldBe(languageNames.of('zh-Hant'), "Chinese, Traditional");
-    else
-        shouldBe(languageNames.of('zh-Hant'), "Traditional Chinese");
+    shouldBe(languageNames.of('zh-Hant'), "Traditional Chinese");
     shouldBe(languageNames.of('en-US'), "American English");
     shouldBe(languageNames.of('zh-TW'), "Chinese (Taiwan)");

@@ -79,10 +76,7 @@ if ($vm.icuVersion() >= 61) {
     shouldBe(languageNames.of('fr'), "French");
     shouldBe(languageNames.of('de'), "German");
     shouldBe(languageNames.of('fr-CA'), "Canadian French");
-    if ($vm.icuVersion() >= 64 && $vm.icuVersion() <= 66)
-        shouldBe(languageNames.of('zh-Hant'), "Chinese, Traditional");
-    else
-        shouldBe(languageNames.of('zh-Hant'), "Traditional Chinese");
+    shouldBe(languageNames.of('zh-Hant'), "Traditional Chinese");
     shouldBe(languageNames.of('en-US'), "US English");
     shouldBe(languageNames.of('zh-TW'), "Chinese (Taiwan)");

@@ -90,10 +84,7 @@ if ($vm.icuVersion() >= 61) {
     shouldBe(languageNames.of('fr'), "French");
     shouldBe(languageNames.of('de'), "German");
     shouldBe(languageNames.of('fr-CA'), "Canadian French");
-    if ($vm.icuVersion() >= 64 && $vm.icuVersion() <= 66)
-        shouldBe(languageNames.of('zh-Hant'), "Chinese, Traditional");
-    else
-        shouldBe(languageNames.of('zh-Hant'), "Traditional Chinese");
+    shouldBe(languageNames.of('zh-Hant'), "Traditional Chinese");
     shouldBe(languageNames.of('en-US'), "US English");
     shouldBe(languageNames.of('zh-TW'), "Chinese (Taiwan)");

And:

diff --git a/JSTests/stress/intl-parse-unicode-subtags.js b/JSTests/stress/intl-parse-unicode-subtags.js
index f087cef4f28..997ade666f7 100644
--- a/JSTests/stress/intl-parse-unicode-subtags.js
+++ b/JSTests/stress/intl-parse-unicode-subtags.js
@@ -45,13 +45,8 @@ if ($vm.icuVersion() >= 61) {
     shouldThrow(() => languageNames.of("root-US"), `RangeError: argument is not a language id`);
     if ($vm.icuVersion() >= 64)
         shouldBe(languageNames.of("es-419"), `Latin American Spanish`);
-    if ($vm.icuVersion() >= 64 && $vm.icuVersion() <= 66) {
-        shouldBe(languageNames.of('zh-Hant'), `Chinese, Traditional`);
-        shouldBe(languageNames.of('zh-Hans-HK'), `Chinese, Simplified (Hong Kong)`);
-    } else {
-        shouldBe(languageNames.of('zh-Hant'), `Traditional Chinese`);
-        shouldBe(languageNames.of('zh-Hans-HK'), `Simplified Chinese (Hong Kong)`);
-    }
+    shouldBe(languageNames.of('zh-Hant'), `Traditional Chinese`);
+    shouldBe(languageNames.of('zh-Hans-HK'), `Simplified Chinese (Hong Kong)`);
     shouldThrow(() => languageNames.of("Hant"), `RangeError: argument is not a language id`); // Script only
     shouldBe(languageNames.of('sr-Latn'), `Serbian (Latin)`); // Language-Script
     shouldBe(languageNames.of('sr-Cyrl'), `Serbian (Cyrillic)`); // Language-Script

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200721/a66c5c05/attachment.htm>