[Webkit-unassigned] [Bug 213374] Bring back llint on x86_32

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=213374

--- Comment #10 from Angelos Oikonomopoulos <angelos at igalia.com> ---
(In reply to Keith Miller from comment #9)
> (In reply to Angelos Oikonomopoulos from comment #6)
> > I should note that the purpose of this patch is not better performance on
> > x86_32. Rather, it is to enable faster testing of llint-related changes on
> > 32-bit platforms.
> 
> Can you clarify how your patch achieves this goal? It's not immediately
> obvious. So it's hard for me to provide actionable feedback.

Thanks for taking a look. The idea is that we get back test results faster on 32-bit X86 so, if llint is being tested there too, developers would get feedback sooner from the EWS if a change they introduce breaks 32-bit platforms.

> (In reply to Angelos Oikonomopoulos from comment #8)
[...]
> > The alternative would be to mediate all accesses to PB via offlineasm macros
> > on all platforms. This way, we don't complicate the llint .asm code for the
> > benefit of a single platform.
> 
> Generally, I'd rather have a special .asm file for X86, if it's particularly
> special. We don't look at the offline assembler code too often, so keeping
> that code as clean as possible has a lot of value.

While I'm not against this in principle, I think it would defeat our purpose here. We're only interested in 32-bit X86 in as much as it shares code paths with the other 32-bit platforms we do care about ;-)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200721/b24d278e/attachment.htm>