[Webkit-unassigned] [Bug 214401] Fix ITP data summary when using the memory store and blocking all third-party cookies

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jul 20 08:56:40 PDT 2020


https://bugs.webkit.org/show_bug.cgi?id=214401

--- Comment #3 from katherine_cheney at apple.com ---
Great catch! I am the engineer who added the ITP data summary, this change looks good. It would be nice to also update the ITP data summary test case in this patch before landing, looks like it is missing the piece of code which turns off database mode.

You can turn it off by adding:

 static bool doneFlag = false;
    [dataStore _setUseITPDatabase:false completionHandler: ^(void) {
        doneFlag = true;
    }];

    TestWebKitAPI::Util::run(&doneFlag);

right after calling 

[dataStore _setResourceLoadStatisticsEnabled:YES] 

in the GetResourceLoadStatisticsDataSummary test in TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm. The test should fail before your change, and pass after.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200720/4134f3ee/attachment.htm>


More information about the webkit-unassigned mailing list