[Webkit-unassigned] [Bug 213374] Bring back llint on x86_32

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jul 20 02:21:28 PDT 2020


https://bugs.webkit.org/show_bug.cgi?id=213374

--- Comment #8 from Angelos Oikonomopoulos <angelos at igalia.com> ---
So, the main thing I'm looking for feedback on is the magical treatment of PB on x86 (32 bits).

Instead of abstracting away all accesses to PB behind offlineasm macros, we leave PB as a register and, on X86,
- - rewrite the actual PB-using instruction to reference a temporary reg (which we get by spilling a value)
- prepend instructions to load the value of PB from the stack in the temporary reg (if it's being read from)
- append instructions to write it back to the stack from the temporary reg

The alternative would be to mediate all accesses to PB via offlineasm macros on all platforms. This way, we don't complicate the llint .asm code for the benefit of a single platform.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200720/77fb05fd/attachment.htm>


More information about the webkit-unassigned mailing list