[Webkit-unassigned] [Bug 214537] New: AccessibilityTable::isDataTable() compares the Color::alphaByte() value to 1, but probably wants to be comparing it to 255

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=214537

            Bug ID: 214537
           Summary: AccessibilityTable::isDataTable() compares the
                    Color::alphaByte() value to 1, but probably wants to
                    be comparing it to 255
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Accessibility
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: sam at webkit.org
                CC: webkit-bug-importer at group.apple.com

While doing some refactoring, changing Color::alpha() to be named Color::alphaByte() to clarify it returns a 0-255 based value, I spotted a use in AccessibilityTable::isDataTable() that compares the Color::alphaByte() value to 1, but probably wants to be comparing it to 255 (or checking isOpaque()).

We should verify that assumption, fix it and add a test.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200719/e5a7dc35/attachment.htm>