[Webkit-unassigned] [Bug 214532] New: AtomStringImpl should have more addWithStringTableProvider varieties, so Identifier can use them.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=214532

            Bug ID: 214532
           Summary: AtomStringImpl should have more
                    addWithStringTableProvider varieties, so Identifier
                    can use them.
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: JavaScriptCore
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: xc.o.c.1180 at gmail.com

VM already has atomStringTable(), it is more efficient than looking it up.

Currently, there is only one addWithStringTableProvider(StringTableProvider& stringTableProvider, StringImpl* string).

There should be more, for example,
    WTF_EXPORT_PRIVATE static RefPtr<AtomStringImpl> add(const LChar*, unsigned length);
    WTF_EXPORT_PRIVATE static RefPtr<AtomStringImpl> add(const UChar*, unsigned length);

So, Ref<StringImpl> Identifier::add(VM& vm, const T* s, int length) can use them.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200719/9420ca3b/attachment-0001.htm>