[Webkit-unassigned] [Bug 213364] [GStreamer] gst_buffer_unmap: assertion 'GST_IS_BUFFER (buffer)' failed

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=213364

Philippe Normand <pnormand at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #404443|review?                     |review-
              Flags|                            |

--- Comment #2 from Philippe Normand <pnormand at igalia.com> ---
Comment on attachment 404443
  --> https://bugs.webkit.org/attachment.cgi?id=404443
Patch

This looks like a workaround for a bug in the InitData class. As the init data is quite small (IIRC), doesn't it pay off to have mapped buffer there? Can't we just copy it? Also I see the append() method assuming the m_payload is mutable, while the createSharedBuffer() has a comment mentioning it should be considered immutable.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200717/822a1b57/attachment.htm>