[Webkit-unassigned] [Bug 214338] Add some missing boilerplate to help fix build on macOS Big Sur

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 15 11:38:47 PDT 2020


https://bugs.webkit.org/show_bug.cgi?id=214338

--- Comment #11 from Saagar Jha <saagar at saagarjha.com> ---
(In reply to Alex Christensen from comment #8)
> You've actually already done it for the NSImage SPI.

Ha, so I have. Added it to NSAppearance as well.

(In reply to Darin Adler from comment #9)
> Sadly, no, Objective-C class extensions don’t work that way.

Sad :(


> I use separate branches for separate patches, not sure what this means in
> terms of the answer to your question.

I have additional changes locally to that upstream probably doesn't want, like commenting out non-building code that I could't come up with fixes for. Usually I keep things like that permanently unstaged and upload only the changes that are relevant by staging and committing them. As webkit-patch doesn't seem to actually make commits I wasn't sure how to get it to understand the staging area–although if it just doesn't do this I can keep stashing as I was before. (I should note that I am using Git to work with the repository, not Subversion, so this might be a strange thing to try to do.)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200715/f1adca7f/attachment.htm>


More information about the webkit-unassigned mailing list