[Webkit-unassigned] [Bug 214338] Add some missing boilerplate to help fix build on macOS Big Sur

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=214338

Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |darin at apple.com
 Attachment #404316|review?                     |review+
              Flags|                            |

--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 404316
  --> https://bugs.webkit.org/attachment.cgi?id=404316
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=404316&action=review

This is OK, but not entirely correct.

> Source/WebCore/PAL/pal/spi/mac/NSAppearanceSPI.h:37
> + at property (nonatomic, setter=_setUsesMetricsAppearance:) BOOL _usesMetricsAppearance;

No way for you to know this, but this should be:

    - (BOOL)_usesMetricsAppearance;

Could declare it as a property, harmless but not quite right, and there is definitely no setter.

> Source/WebCore/PAL/pal/spi/mac/NSImageSPI.h:38
> ++ (instancetype)_imageWithSystemSymbolName:(NSString *)systemSymbolName;

No way for you to know this, but the return type should not be (instancetype). It should be like this instead:

    + (nullable NSImage *)_imageWithSystemSymbolName:(NSString *)name;

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200715/23369d04/attachment-0001.htm>