[Webkit-unassigned] [Bug 214142] [WTF] Fix PackedAlignedPtr for X86_64 canonical addresses

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=214142

--- Comment #36 from Mark Lam <mark.lam at apple.com> ---
(In reply to Jim Mason from comment #35)
> (In reply to Jim Mason from comment #34)
> > (In reply to Mark Lam from comment #32)
> > > nit: while you’re adding the ChangeLog, can you also flip these 2 cases so
> > > that we can test for CPU(X86_64) && (OS(DARWIN) || OS(LINUX) || OS(WINDOWS))
> > > instead?  It’s better to test for a positive condition than a negative one.
> > 
> > I am having a doubt now.  The #else will now run for all CPUs and OSes not
> > named in the #if, not just X86_64.  I don't think that is right.  Anything
> > not X86_64 ought to be running the same test as in the #if.
> 
> I think the correct test with the sense reversed would be:
> 
> #if !CPU(X86_64) || OS(DARWIN) || OS(LINUX) || OS(WINDOWS)
>    ... run the legacy test ...
> #else
>    ... run the new min/max upper test ...
> #endif

You are correct.  Sorry about that.  Can you fix the patch?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200714/f62ecfd2/attachment-0001.htm>