[Webkit-unassigned] [Bug 214142] [WTF] Fix PackedAlignedPtr for X86_64 canonical addresses

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=214142

Mark Lam <mark.lam at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #404218|review?                     |review-
              Flags|                            |

--- Comment #32 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 404218
  --> https://bugs.webkit.org/attachment.cgi?id=404218
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=404218&action=review

r- because of the missing ChangeLog.

> Tools/TestWebKitAPI/Tests/WTF/Packed.cpp:69
> +#if CPU(X86_64) && !(OS(DARWIN) || OS(LINUX) || OS(WINDOWS))

nit: while you’re adding the ChangeLog, can you also flip these 2 cases so that we can test for CPU(X86_64) && (OS(DARWIN) || OS(LINUX) || OS(WINDOWS)) instead?  It’s better to test for a positive condition than a negative one.

> Tools/TestWebKitAPI/Tests/WTF/Packed.cpp:73
> +            // Other OSes will never allocate user space addresses with

Since we’re no testing for OS(SOLARIS), can you change this comment to say “These OSes” instead of “Other OSes”?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200714/7cf81457/attachment.htm>